Make keynote bench job reusable#5433
Merged
Merged
Conversation
joshua-spacetime
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
June 23, 2026 18:10
bfops
reviewed
Jun 24, 2026
bfops
reviewed
Jun 24, 2026
bfops
approved these changes
Jun 24, 2026
joshua-spacetime
force-pushed
the
joshua/reusable-keynote-bench
branch
from
June 24, 2026 20:43
29632d7 to
f1848bc
Compare
joshua-spacetime
enabled auto-merge
June 25, 2026 01:37
cloutiertyler
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Makes the keynote benchmark job reusable so that it can be invoked and run in other CI environments.
API and ABI breaking changes
N/A
Expected complexity level and risk
2
Testing
Refactor. Relies on existing coverage.